[PW_SID:1146634] wiphy: do not select FT AKMs if we are going to reject them later - #513
[PW_SID:1146634] wiphy: do not select FT AKMs if we are going to reject them later#513IWDTestBot wants to merge 1 commit into
Conversation
The condition for choosing a FT AKM for SAE does not match the condition used further down the line to validate the permissibility of an FT AKM. Make a minimal change to bring the two in line, just to prevent choosing a FT AKM that we are going to reject anyway. Tested on a BCM43455 (brcmfmac) device, firmware 7.45.265 (28bca26 CY), where this change [among others] allows to associate with a network that advertises WPA3-Personal+FT (w/o FT actually being used). Without this change, the FT AKM is selected, subsequently triggering an assertion and failing the association. See: f5c5efa ("wiphy: allow FT AKM to be used if Auth/Assoc is not supported") Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
|
Fetch PR Prep - Setup ELL Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches |
|
Fetch PR GitLint Output: Prep - Setup ELL Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches Autotest Runner Clang Build |
2 participants
The condition for choosing a FT AKM for SAE does not match the condition
used further down the line to validate the permissibility of an FT AKM.
Make a minimal change to bring the two in line, just to prevent choosing
a FT AKM that we are going to reject anyway.
Tested on a BCM43455 (brcmfmac) device, firmware 7.45.265 (28bca26 CY),
where this change [among others] allows to associate with a network that
advertises WPA3-Personal+FT (w/o FT actually being used). Without this
change, the FT AKM is selected, subsequently triggering an assertion
and failing the association.
See: f5c5efa ("wiphy: allow FT AKM to be used if Auth/Assoc is not supported")
Signed-off-by: Ivan Shapovalov intelfx@intelfx.name
Note that the resulting condition (which I wrote to mirror condition in
netdev_handshake_state_setup_connection_type()) differs from the similar
condition for WPA2-FT just below, which also checks for 4-way handshake
offload in the !softmac arm:
WPA3-FT: (IE_AKM_IS_FT() && (softmac || roam_offload))
WPA2-FT: (IE_AKM_IS_FT() && (softmac || (psk_offload && roam_offload))
I do not have enough knowledge to tell if this is an omission or a
deliberate asymmetry between WPA2 and WPA3 implementations.
src/netdev.c | 7 +++++++
src/wiphy.c | 20 ++++++++++++++++----
2 files changed, 23 insertions(+), 4 deletions(-)
base-commit: d003d0e
change-id: 20260816-brcmfmac-ft-12fe2dfeb3ef
Best regards,
Ivan Shapovalov intelfx@intelfx.name